Value::update performance enhancement & simplification#521
Open
zakalibit wants to merge 3 commits intoapache:trunkfrom
Open
Value::update performance enhancement & simplification#521zakalibit wants to merge 3 commits intoapache:trunkfrom
zakalibit wants to merge 3 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
any update on this one? |
Contributor
|
@zakalibit No update yet, but it is on my list. I'll get to it as soon as I can! |
mpenick
reviewed
Dec 8, 2021
| } | ||
| } else { | ||
| count_ = 0; | ||
| if (!is_null_ && data_type_->is_collection()) { |
Contributor
There was a problem hiding this comment.
Doesn't this result in an invalid count for tuples and UDTs?
Contributor
Author
|
@mpenick any chance to get this PR reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no point updating the
count_in theValue::update()for types other than collection type.This change saves another 15% ish in
cass_iterator_next